[Backend] claimable.service.ts cache key does not include token addre… - #1075
Open
BigMick03 wants to merge 3 commits into
Open
[Backend] claimable.service.ts cache key does not include token addre…#1075BigMick03 wants to merge 3 commits into
BigMick03 wants to merge 3 commits into
Conversation
…ss, so streams with the same id across tokens could collide
ogazboiz
requested changes
Aug 3, 2026
ogazboiz
left a comment
ogazboiz
left a comment
Contributor
There was a problem hiding this comment.
the cross-token cache test is nice and the defensive intent is fine (streamId is @unique so the practical risk is low). one real blocker:
- the service uses stream.tokenAddress but ClaimableStreamState (claimable.service.ts:6-18) never gains a tokenAddress field, which is a TS2339 compile error currently masked by the earlier npm ci failure. add tokenAddress: string to the interface and the result select typing.
- fill in the PR template body.
- rebase and re-run now that main is green again.
if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ss, so streams with the same id across tokens could collide
Description
Type of Change
Related Issues
Closes #1021
Changes Made
Testing
Test Coverage
Test Steps
Breaking Changes
Breaking Changes:
Migration Guide:
Screenshots/Demo
Checklist
Additional Notes